-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Support for New Semantic Release Version. #137
Conversation
Use temporary forks with pmowrer/semantic-release-monorepo#137 and pmowrer/semantic-release-plugin-decorators#31 applied to work around pmowrer/semantic-release-monorepo#136
I think this might need a further fix in https://github.com/semantic-release/semantic-release - I'm experimenting with a fork containing this PR and pmowrer/semantic-release-plugin-decorators#31 and get:
|
@achingbrain I went down the same rabbit hole, and discovered that according to the comment in
So the following configuration works:
Not sure why they didn't replace
|
Any update on this? |
@pmowrer can you merge this? |
Can this get merged? This is a pretty big issue as it forces users of semantic-release-monorepo to downgrade plugins that are now ESM only. |
FYI - I created #138 to document which plugins need to be downgraded due to lack of ESM support in semantic-release-monorepo. |
Even if this was merged, the build is broken. This project relied on travis-ci but that appears to have been busted a long time ago when travis-ci underwent big changes. The build process needs to be moved to github actions |
That's good context @pmowrer. I also don't even know if this change works or solves the problems it needs to. Do you think you could create an issue for fixing the build and explaining what needs to be done? Then maybe someone in the community can work on it. Not sure if that requires adding some users with higher permissions to this project to set up GitHub actions. |
Need to wait until pmowrer/semantic-release-monorepo#137 is merged
Any ETA on this being merged / published? Is there something blocking these changes from going in? |
Fix relase by downgrading various semantic relase plugins until pmowrer/semantic-release-monorepo#137 is merged
Any updates on this? |
I think this pr should be simplified. Just convert the project to esm and support new semantic release versions. It should be easier to review with fewer changes. |
@bryanjtc It sounds like another hurdle is that the build for this project is broken and needs to be fixed. |
I created a new pr, without the prettier changes to make reviewing them easier. See: #143 |
I removed the custom patch and bundled code as solution for this comment: #143 (comment) |
🎉 This issue has been resolved in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for getting this out. Huge quality of life improvement :) |
Please
I need to merge theses changes.
Theses changes resolve next error (ERR_REQUIRED_ESM)